[BUG] Trim colon from binds to prevent Named parameter "text_ma_xxx" does not have a bound value error on matchAgainst search
#141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not have a bound value` error on matchAgainst search
…y finished words, resulting in a wider range of results. Useful for searches, that need to include word combinations
|
I additionally added the option to use This is not actually related to the bug, if you don't see the need for extending the search, kindly disregard that! :) |
…of the searchword
|
Tnx for this fix and new feature. For now I merged only the bugfix because while integrating your boolean mode I refactored whole SearchFilter a bit and added postman testes which is still work in progress. Will merge that next weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the
matchAgainststrategy, i ran into the following error:Named parameter "text_ma_0" does not have a bound value. This results in the SearchFilter with matchAgainst being un-useable.This seems to happen as the binds are getting added to the QueryBuilder. To fix this problem, the colon which is previously used for the parameter, needs to be removed before adding it to the Query.
Tested on macOS 15.5 with TYPO3 13.4.14 and PHP 8.3.